https://bugs.freedesktop.org/show_bug.cgi?id=93783
Bug ID: 93783
Summary: [regression, bisected]
arb_shader_image_load_store.compiler.declaration-forma
t-qualifier-duplicate
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity: normal
Priority: medium
Component: Drivers/DRI/i965
Assignee: idr at freedesktop.org
Reporter: mark.a.janes at intel.com
QA Contact: intel-3d-bugs at lists.freedesktop.org
arb_shader_image_load_store.compiler.declaration-format-qualifier-duplicate.frag
and
arb_shader_image_load_store.compiler.declaration-format-qualifier-duplicate.vert
regressed on mesa 6a660a5f5dad02a6594ea905c511ba3cae6862a5
glsl: allow multiple layout qualifiers for a single declaration
From the ARB_shading_language_420pack spec:
"More than one layout qualifier may appear in a single
declaration. If the same layout-qualifier-name occurs in
multiple layout qualifiers for the same declaration, the
last one overrides the former ones."
The parser was already failing correctly when the extension is
not available but testing for duplicates within a single layout
qualifier was still causing this to fail when available as both
cases share the same function for merging.
Here we add a parameter to differentiate between the two uses
and apply it to the duplicate test.
However, the piglit test's output references a different part of the spec in
asserting that multiple layout qualifiers are not permitted:
/tmp/build_root/m64/lib/piglit/bin/glslparsertest
/tmp/build_root/m64/lib/piglit/generated_tests/spec/ARB_shader_image_load_store/compiler/declaration-format-qualifier-duplicate.frag
fail 1.50 GL_ARB_shader_image_load_store
piglit: debug: Requested an OpenGL 3.2 Core Context, and received a matching
3.3 context
Shader source:
/*
* [config]
* expect_result: fail
* glsl_version: 1.50
* require_extensions: GL_ARB_shader_image_load_store
* [end config]
*/
#version 150
#extension GL_ARB_shader_image_load_store: require
/*
* From the ARB_shader_image_load_store spec:
*
* "Only one format qualifier may be specified for any image variable
* declaration."
*/
layout(rgba32f) layout(rgba32f) uniform image2D img;
void main()
{
}
Standard Error
Successfully compiled fragment shader
/tmp/build_root/m64/lib/piglit/generated_tests/spec/ARB_shader_image_load_store/compiler/declaration-format-qualifier-duplicate.frag:
--
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20160119/d1c885ca/attachment.html>