[Bug 93696] [HSW,BDW;SKL][GLES 3.1 CTS]ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max-* fail

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jan 19 23:41:59 PST 2016


https://bugs.freedesktop.org/show_bug.cgi?id=93696

Tapani Pälli <lemody at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Tapani Pälli <lemody at gmail.com> ---
commit 4475d8f9169195baefa893b9b147fe20414cda7c
Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Fri Jan 15 13:11:20 2016 +0200

    glsl: move uniform calculation to link_uniforms

    Patch moves uniform calculation to happen during link_uniforms, this
    is possible with help of UniformRemapTable that has all the reserved
    locations.

    Location assignment for implicit locations is changed so that we
    utilize also the 'holes' that explicit uniform location assignment
    might have left in UniformRemapTable, this makes it possible to fit
    more uniforms as previously we were lazy here and wasting space.

    Fixes following CTS tests:
       ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max
      
ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max-array

    v2: code cleanups, increment NumUniformRemapTable correctly, fix
        find_empty_block to work properly and add some more comments.

    Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
    Reviewed-by: Marta Lofstedt <marta.lofstedt at intel.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20160120/8134d7c3/attachment.html>


More information about the intel-3d-bugs mailing list