[Bug 93717] Meta mipmap generation can corrupt texture state

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 25 10:45:56 PST 2016


https://bugs.freedesktop.org/show_bug.cgi?id=93717

Ian Romanick <idr at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Ian Romanick <idr at freedesktop.org> ---
Should be fixed by the following commit.

commit 2542871387393e855f6afe6c94d44611eefaf6eb
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Tue Jan 12 16:37:27 2016 -0800

    meta: Use internal functions to set texture parameters

    _mesa_texture_parameteriv is used because (the more obvious)
    _mesa_texture_parameteri just stuffs the parameter in an array and calls
    _mesa_texture_parameteriv.  This just cuts out the middleman.

    As a side bonus we no longer need check that ARB_stencil_texturing is
    supported.  The test doesn't allow non-supporting implementations to
    avoid any work, and it's redundant with the value-changed test.

    Fix bug #93717 because the state restore commands at the bottom of
    _mesa_meta_GenerateMipmap no longer depend on the bound state.

    Fixes  piglit   arb_direct_state_access-generatetexturemipmap  with  the
    changes  recently sent  to the  piglit mailing  list.  See  the bugzilla
    entry for more info.

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93717
    Cc: "11.0 11.1" <mesa-stable at lists.freedesktop.org>
    Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20160125/ca617d84/attachment.html>


More information about the intel-3d-bugs mailing list