[Bug 89607] Assertion hit in opt_array_splitting with recursive array indexing

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Mar 8 09:41:52 UTC 2016


Timothy Arceri <t_arceri at yahoo.com.au> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Timothy Arceri <t_arceri at yahoo.com.au> ---
Fixed by:

commit    4a600024242be2b8684ab2cc215171f31db594b0

glsl/opt_array_splitting: Fix crash when doing array indexing into other arrays

When we find indirect indexing into an array, the current implementation
of the array spliiting optimization pass does not look further into the
expression tree. However, if the variable expression involves variable
indexing into other arrays, we can miss that these other arrays also have
variable indexing. If that happens, the pass will crash later on after
hitting an assertion put there to ensure that split arrays are in fact
always indexed via constants:

shader_runner: opt_array_splitting.cpp:296:
void ir_array_splitting_visitor::split_deref(ir_dereference**): Assertion
`constant' failed.

This patch fixes the problem by letting the pass step into the variable
index expression to identify these cases properly.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89607
Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20160308/e859ad2a/attachment-0001.html>

More information about the intel-3d-bugs mailing list