[Bug 81585] piglit spec_glsl-1.10_compiler_literals_invalid-float-suffix-capital-f.vert fails

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Mar 30 04:32:05 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=81585

Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
           Assignee|idr at freedesktop.org         |chemecse at gmail.com
             Status|NEW                         |RESOLVED

--- Comment #5 from Kenneth Graunke <kenneth at whitecape.org> ---
Fixed by:

commit 6773128bbf8703663ed1a4d6c1c3308b3c002a35
Author: Lars Hamre <chemecse at gmail.com>
Date:   Mon Mar 28 20:42:14 2016 -0400

    glsl: invalidate float suffixes for GLSL 1.10 and GLSL ES 1.00

    Float suffixes are not allowed in GLSL 1.10 nor GLSL ES 1.00.

    Fixes the following piglit tests:
    tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-capital-f.vert
    tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-f.vert`

    v2: modify error message
    v3: parse the float instead of returning an ERROR_TOK
    v4: (by Ken) Change to is_version(120, 300) to avoid breaking ES3
        shaders; update commit message accordingly.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81585
    Signed-off-by: Lars Hamre <chemecse at gmail.com>
    Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20160330/3f996124/attachment.html>


More information about the intel-3d-bugs mailing list