[Bug 102260] 15% perf drop in DrvRes with "i965/miptree: Use num_samples of 1 instead of 0 for single-sampled"

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=102260

Jason Ekstrand <jason at jlekstrand.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jason Ekstrand <jason at jlekstrand.net> ---
This is fixed by the following commit:

commit f24cf82d6db290a88abfff0669d2c5e2aa463901
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Sat Aug 19 11:03:38 2017 -0700

    i965/tex: Don't pass samples to miptree_create_for_teximage

    In 76e2f390f9863a35, when Topi switched num_samples from 0 to 1 for
    single-sampled, he accidentally switched the last parameter in the call
    to miptree_create_for_teximage from 0 to 1 thinking it was num_samples
    when it was actually layout_flags.  Switching from 0 to 1 added the
    MIPTREE_LAYOUT_ACCELERATED_UPLOAD flag which causes us to allocate a
    busy BO instead of an idle one.  This caused the subsequent CPU upload
    to consistently stall.  The end result was a 15% performance drop in the
    SynMark v7 DrvRes microbenchmark.  This restores the old behavior and
    fixes the performance regression.

    Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
    Fixes: 76e2f390f9863a356d1419982dec705260d67eff
    Bugzilla: https://bugs.freedesktop.org/102260
    Cc: mesa-stable at lists.freedesktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20170819/1d9f4914/attachment.html>