[Bug 101678] 5-10% drop in Lightsmark2008 from "i965/miptree: Store fast clear colors in an isl_color_value"

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101678

--- Comment #2 from Eero Tamminen <eero.t.tamminen at intel.com> ---
On quick testing, that patch doesn't have any effect.


The regression went away already earlier, with this commit:
---------------------------------------------
commit 6db193701e7d03e0eadd54fc3e1b3d75719bc4ae
Author:     Jason Ekstrand <jason at jlekstrand.net>
AuthorDate: Wed Jun 14 18:54:28 2017 -0700
Commit:     Kenneth Graunke <kenneth at whitecape.org>
CommitDate: Wed Jul 26 14:43:01 2017 -0700

    i965: Only do depth resolves prior to clearing when needed

    When changing the clear value, we need to resolve any fast cleared data.

    Previously, we were performing resolves on every slice with HiZ enabled.
    We only need to resolve slices that a) have fast clear data, and b)
    aren't about to be cleared to the new color.  In the latter case, we
    were actually doing a resolve, and then a fast clear - when we could
    skip both, causing the existing fast cleared area to be updated to the
    new clear value for no additional work.

    This patch stops using intel_miptree_prepare_access in favor of a more
    optimal open coded loop that knows about our clear operation.

    v2: (by Ken) Rebase on islification, write a real commit message.
---------------------------------------------

(I bisected it last week, but hadn't yet had time to update this bug.  That
change didn't effect other benchmarks.)

If you think that's enough, please mark this bug as fixed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20170821/8302be6a/attachment-0001.html>