[Bug 104226] [bisected] Anvil accesses uninitialized memory while compiling shaders

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=104226

--- Comment #12 from Francisco Jerez <currojerez at riseup.net> ---
(In reply to Józef Kucia from comment #11)
> (In reply to Francisco Jerez from comment #10)
> > Created attachment 136240 [details] [review] [review]
> > 0001-intel-fs-bank_conflicts-Use-posix_memalign-instead-o.patch
> > 
> > I think I would prefer to address the problem at the allocation point as in
> > the attached patch.  Can you confirm whether the attachment fixes the crash
> > for you since I'm unable to reproduce it?
> The patch fixes the crash.

Great, I'll send it for review once I get some results from our CI.

> I'm not sure if it's the best solution though, e.g. _mesa_align_malloc() might
> be preferred instead of posix_memalign().

I shortly considered using _mesa_align_malloc(), however I don't think it's
available to the vulkan driver.  Not a big deal, I think posix_memalign should
be fine, the i965 driver is not expected to run on Windows.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20171217/6fe9b638/attachment-0001.html>