[Bug 99287] piglit.spec.glsl-1_10.execution.vs-nested-return-sibling-loop regression

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=99287

Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Kenneth Graunke <kenneth at whitecape.org> ---
Fixed:

commit a4d6f4d954d8539c3effbbc3af7f74e9dae32e2c
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Thu Jan 5 10:46:39 2017 -0800

    i965: Don't set EmitNoMainReturn.

    A while ago, we stopped using Luca's GLSL IR lower_jumps pass in favor
    of nir_lower_returns().  Marek's commit d3cb79e043338b0e55a3fba8df652f3
    put it in do_common_optimization, which resulted in us calling it again.

    Dropping the EmitNoMainReturn setting makes us skip that pass again.

    Apparently that pass doesn't work properly, because this fixes Piglit's
    tests/spec/glsl-1.10/execution/vs-nested-return-sibling-loop.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99287
    Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
    Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20170106/7e8a9233/attachment.html>