[Bug 101678] 5-10% drop in Lightsmark2008 from "i965/miptree: Store fast clear colors in an isl_color_value"

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101678

            Bug ID: 101678
           Summary: 5-10% drop in Lightsmark2008 from "i965/miptree: Store
                    fast clear colors in an isl_color_value"
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/i965
          Assignee: intel-3d-bugs at lists.freedesktop.org
          Reporter: eero.t.tamminen at intel.com
        QA Contact: intel-3d-bugs at lists.freedesktop.org

Lightsmark2008 performance dropped by 5-10% on all machines (GEN6+) on Jun 7th.
 EzBench bisected that to:
----------------------------------------------------------
AuthorDate: Sat May 20 15:00:42 2017 -0700
Commit:     Jason Ekstrand <jason.ekstrand at intel.com>
CommitDate: Wed Jun 7 08:54:54 2017 -0700

    i965/miptree: Store fast clear colors in an isl_color_value

    This commit, out of necessity, makes a number of changes at once:

     1) Changes intel_mipmap_tree to store the clear color for both color
        and depth as an isl_color_value.

     2) Changes the depth/stencil emit code to do the format conversion of
        the depth clear value on Haswell and earlier instead of pulling a
        uint32_t directly from the miptree.

     3) Changes ISL's depth/stencil emit code to perform the format
        conversion of the depth clear value on Haswell and earlier instead
        of assuming that the depth value in the float is pre-converted.

     4) Changes blorp to pass the depth value through as a float.

     5) Changes the Vulkan driver to pass the depth value to blorp as a
        float rather than a uint.

    Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Reviewed-by: Chad Versace <chadversary at chromium.org>
----------------------------------------------------------

No other benchmarks besides Lightsmark2008 were affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20170703/b21de62f/attachment.html>