[Bug 101910] [BYT] ES31-CTS.functional.copy_image.non_compressed.viewclass_96_bits.rgb32f_rgb32f

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jul 25 13:11:29 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=101910

--- Comment #2 from Topi Pohjolainen <topi.pohjolainen at intel.com> ---
Well, the difference is valign 2 vs 4. Forcing valign 4 even for linear with
RGB32F:

diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c
index 24d411f..57751ea 100644
--- a/src/intel/isl/isl_gen7.c
+++ b/src/intel/isl/isl_gen7.c
@@ -383,7 +383,13 @@ isl_gen7_choose_image_alignment_el(const struct isl_device
*dev,
    assert(!(require_valign4 && gen7_format_needs_valign2(dev, info->format)));

    /* We default to VALIGN_2 because it uses the least memory. */
-   const uint32_t valign = require_valign4 ? 4 : 2;
+   uint32_t valign = require_valign4 ? 4 : 2;
+
+   /* In practise it looks that even as linear tiled this has to be programmed
+    * to 4 on BayTrail.
+    */
+   if (info->format == ISL_FORMAT_R32G32B32_FLOAT && ISL_DEV_IS_BAYTRAIL(dev))
+      valign = 4;

    *image_align_el = isl_extent3d(halign, valign, 1);
 }


fixes the tests.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20170725/67dea11c/attachment.html>


More information about the intel-3d-bugs mailing list