[Bug 103322] i965: dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 takes 3m22s to compile

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=103322

Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Kenneth Graunke <kenneth at whitecape.org> ---
Fixed by:

commit 68f69ebdccca16246bafd86e86ed80fab369009b
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Tue Oct 17 23:19:20 2017 -0700

    i965: Use is_scheduling_barrier instead of schedule_node::is_barrier.

    Commit a73116ecc60414ade89802150b tried to make add_barrier_deps()
    walk to the next barrier, and stop.  To accomplish that, it added an
    is_barrier flag.  Unfortunately, this only works half of the time.

    The issue is that add_barrier_deps() walks both backward (to the
    previous barrier), and forward (to the next barrier).  It also sets
    is_barrier.  Assuming that we're processing instructions in forward
    order, this means that is_barrier will be set for previous instructions,
    but not future ones.  So we'll never see it, and walk further than we
    need to.

    dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23
    now compiles its shaders in 3.6 seconds instead of 3.3 minutes.

    Reviewed-by: Matt Turner <mattst88 at gmail.com>
    Tested-by: Pallavi G <pallavi.g at intel.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20171019/0e2fcd41/attachment.html>