[Bug 103085] [ivb byt hsw] piglit.spec.arb_indirect_parameters.tf-count-arrays

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=103085

Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Kenneth Graunke <kenneth at whitecape.org> ---
Fixed by:

commit 048d4c45c94eb8d99f2a53f3bf200b2c6a9f9629
Author: Plamena Manolova <plamena.manolova at intel.com>
Date:   Mon Oct 30 21:14:24 2017 +0000

    i965: Fix ARB_indirect_parameters logic.

    This patch modifies the ARB_indirect_parameters logic in
    brw_draw_prims, so that our implementation isn't affected if
    another application attempts to use predicates. Previously we
    were using a predicate with a DELTAS_EQUAL comparison operation
    and relying on the MI_PREDICATE_DATA register being 0. Our code
    to initialize MI_PREDICATE_DATA to 0 was incorrect, so we were
    accidentally using whatever value was written there. Because the
    kernel does not initialize the MI_PREDICATE_DATA register on
    hardware context creation, we might inherit the value from whatever
    context was last running on the GPU (likely another process).
    The Haswell command parser also does not currently allow us to write
    the MI_PREDICATE_DATA register. Rather than fixing this and requiring
    an updated kernel, we switch to a different approach which uses a
    SRCS_EQUAL predicate that makes no assumptions about the states of any
    of the predicate registers.

    Fixes Piglit's spec/arb_indirect_parameters/tf-count-arrays test.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103085
    Signed-off-by: Plamena Manolova <plamena.manolova at intel.com>
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20171031/b98d2dbb/attachment-0001.html>