[Bug 106590] Wrong line numbers expanded while compiling shaders

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Aug 21 05:45:32 UTC 2018


--- Comment #7 from Zhaowei Yuan <zhaowei.yuan at samsung.com> ---
(In reply to Kenneth Graunke from comment #6)
> (In reply to Mark Janes from comment #5)
> > This seems like a duplicate of 
> > 
> >  https://bugs.freedesktop.org/show_bug.cgi?id=106807
> > 
> > My faint recollection is that the specification of the __LINE__ macro is
> > inconsistent.  If, as Ken says, this has been removed from the
> > specification, why are we looking at patches to change the implementation?
> No, __LINE__ is perfectly well defined and not going away.  #line directives
> to alter the current line using expressions is going away.  I'm pretty sure
> Zhaowei Yuan's patch fixes a real bug we've had for a long time.

Thanks. However, I'm not sure my patch is the best solution, hope someone can
review it and give me some suggestion

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20180821/e80c857c/attachment.html>

More information about the intel-3d-bugs mailing list