[Bug 104335] [OpenGL CTS][SKL,KBL] KHR-GL45.vertex_attrib_64bit.limits_test occasionally fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=104335

Iago Toral <itoral at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Iago Toral <itoral at igalia.com> ---
Fixed with:

commit f474b19875a7c51ced6bb986e5733379b2780dcf
Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Thu Jan 4 03:55:13 2018 +0100

    i965: allocate a SGVS element when VertexID or InstanceID are read

    Although on gen8+ platforms we can in theory use 3DSTATE_VF_SGVS
    to put these beyond the last vertex element it seems that we still
    need to allocate the SVGS element, otherwise we have observed cases
    where we end up reading garbage. Specifically, the CTS test mentioned
    below was flaky with a fail rate of ~1% on some gen9+ platforms caused
    by reading garbage for the gl_InstanceID value. The flakyness goes
    away as soon as we start allocating the SVGS element.

    v2:
      - Do this for gen8+, not just gen9+, and pull the boolean
        outside the #if block (Jason)

    Fixes flaky test:
    KHR-GL45.vertex_attrib_64bit.limits_test

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104335
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20180207/1d144e8d/attachment-0001.html>