[Bug 105183] Weird assertion in NIR linker

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105183

            Bug ID: 105183
           Summary: Weird assertion in NIR linker
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: glsl-compiler
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: idr at freedesktop.org
        QA Contact: intel-3d-bugs at lists.freedesktop.org

GCC issues the following warning in my build:

In file included from ../../SOURCE/master/src/compiler/glsl_types.h:29:0,
                 from ../../SOURCE/master/src/compiler/nir_types.h:36,
                 from ../../SOURCE/master/src/compiler/nir/nir.h:39,
                 from
../../SOURCE/master/src/compiler/nir/nir_linking_helpers.c:24:
../../SOURCE/master/src/compiler/nir/nir_linking_helpers.c: In function
‘remap_slots_and_components’:
../../SOURCE/master/src/compiler/nir/nir_linking_helpers.c:286:63: warning:
ordered comparison of pointer with integer zero [-Wextra]
          assert(remap[var->data.location - VARYING_SLOT_VAR0] >= 0);
                                                               ^

I looked at the code, and remap is declared as "struct varying_loc
(*remap)[4]".  It is comparing that a pointer to an array of 4 structures is >=
0.  I'm not sure what the original intention was, but this tautology isn't
doing it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20180221/43b0057d/attachment.html>