[Bug 104794] piglit.spec.arb_internalformat_query2.samples and num_sample_counts pname checks

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Feb 23 10:54:35 UTC 2018


--- Comment #1 from Antia Puentes <apuentes at igalia.com> ---
This should be fixed now.

The commit originating the regressions was reverted by me, however, in issue 
https://github.com/KhronosGroup/OpenGL-API/issues/32 it was clarified that the
commit implemented the correct behaviour.

Commit is now restored in Mesa master and the regressions fixed in Piglit.

** Mesa **

commit e1623b303ccc7a880e34bddef7231dcf230826b3
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Mon Jan 15 10:58:50 2018 +0000

    mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

    RGB9_E5 should be accepted by RenderbufferStorage if the
    EXT_texture_shared_exponent is exposed. It is left to the
    implementations to return GL_FRAMEBUFFER_UNSUPPORTED_EXT
    when checking the framebuffer completeness if they do not
    support rendering in this format.

    Discussed in:

    This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5

    v2: Added more info to the commit message (Antia)

    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Reviewed-by: Antia Puentes <apuentes at igalia.com>

** Piglit **

commit 5f11fdff7b329eb5712eed98f783a6164410336f
Author: Antia Puentes <apuentes at igalia.com>
Date:   Tue Feb 20 13:55:13 2018 +0100

    internalformat_query*: fix SAMPLES pname checks for RGB9_E5

    SAMPLES and NUM_SAMPLE_COUNTS queries accept internalformats which
    are defined as color-, depth- or stencil-renderable. RGB9_E5 is marked
    as non color-renderable in OpenGL 4.6, however if the
    EXT_texture_shared_exponent extension is exposed it must be considered
    as such. The later was discussed in:

    v2: use 'tex' as shortname for texture instead of 'text' (Piñeiro)

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104794

    Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20180223/1228e4fd/attachment.html>

More information about the intel-3d-bugs mailing list