[Bug 104668] dEQP-GLES31.functional.shaders.linkage.uniform.block.differing_precision regression

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=104668

            Bug ID: 104668
           Summary: dEQP-GLES31.functional.shaders.linkage.uniform.block.d
                    iffering_precision regression
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Keywords: bisected, regression
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/i965
          Assignee: jasuarez at igalia.com
          Reporter: mark.a.janes at intel.com
        QA Contact: intel-3d-bugs at lists.freedesktop.org
                CC: lemody at gmail.com

bisected to:
Author:     Juan A. Suarez Romero <jasuarez at igalia.com>
glsl/linker: link-error using the same name in unnamed block and outside

According with OpenGL GLSL 4.20 spec, section 4.3.9, page 57:

   "It is a link-time error if any particular shader interface
    contains:
      - two different blocks, each having no instance name, and each
        having a member of the same name, or
      - a variable outside a block, and a block with no instance name,
        where the variable has the same name as a member in the block."

This means that it is a link error if for example we have a vertex
shader with the following definition.

  "layout(location=0) uniform Data { float a; float b; };"

and a fragment shader with:

  "uniform float a;"

As in both cases we refer to both uniforms as "a", and thus using
glGetUniformLocation() wouldn't know which one we mean.

This fixes KHR-GL*.shaders.uniform_block.common.name_matching.

v2: add fixed tests (Tapani)

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
------------------------------------------------------------------
Standard Output

Expecting shader compilation and program linking to succeed. Resulting program
will not be executed.
ERROR: expected shaders to compile and link properly, but failed to link.

------------------------------------------------------------------

Since the commit message indicates a similar fixed test, it may be possible
that dEQP has a bug which has not been fixed on AOSP/master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20180116/d716938e/attachment.html>