[Bug 104690] [G33] regression: piglit.spec.!opengl 1_4.draw-batch and gl-1_4-dlist-multidrawarrays

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 18 21:37:48 UTC 2018


https://bugs.freedesktop.org/show_bug.cgi?id=104690

            Bug ID: 104690
           Summary: [G33] regression: piglit.spec.!opengl 1_4.draw-batch
                    and gl-1_4-dlist-multidrawarrays
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/i965
          Assignee: brianp at vmware.com
          Reporter: clayton.a.craft at intel.com
        QA Contact: intel-3d-bugs at lists.freedesktop.org
                CC: idr at freedesktop.org

Mesa 8e4efdc895eacca931b94a0c1fa01aae5c34463b introduced a regression on G33
for the following tests:

piglit.spec.!opengl 1_4.draw-batch
piglit.spec.!opengl 1_4.gl-1_4-dlist-multidrawarrays

commit 8e4efdc895eacca931b94a0c1fa01aae5c34463b
Author: Brian Paul <brianp at vmware.com>
Date:   Fri Jan 12 13:18:25 2018 -0700

    vbo: optimize some display list drawing (v2)

    The vbo_save_vertex_list structure records one or more glBegin/End
    primitives which all have the same vertex format.


    To draw these primitives, we setup the vertex array state, then
    issue the drawing command.  Before, the 'start' vertex was typically
    zero and we used the vertex array pointer to indicate where the
    vertex data starts.

    This patch checks if the vertex buffer offset is an exact multiple of
    the vertex size.  If so, that means we can use zero-based vertex array
    pointers and use the draw's start value to indicate where the vertex
    data starts.

    This means a series of display list drawing commands may have
    identical vertex array state.  This will get filtered out by the
    Gallium CSO module so we can issue a tight series of drawing commands
    without state changes to the device.

    Note that this also works for a series of glCallList commands (not
    just one list that contains multiple glBegin/End pairs).

    No Piglit or conform changes.

    v2: minor fixes suggested by Ian.

    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20180118/14fb173e/attachment-0001.html>


More information about the intel-3d-bugs mailing list