[Bug 106668] Aperture space rollback snafu

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106668

            Bug ID: 106668
           Summary: Aperture space rollback snafu
           Product: Mesa
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/i965
          Assignee: intel-3d-bugs at lists.freedesktop.org
          Reporter: chris at chris-wilson.co.uk
        QA Contact: intel-3d-bugs at lists.freedesktop.org

Since we may update context state as we compute the batch, that state is
preserved as we rollback the batch for a failed aperture check -- the
subsequent emission then skips the atoms as the context state is believed to
match requirements.

E.g. gen7_upload_urb(). 

Affects:
genX(blorp_exec)
brw_dispatch_compute_common
brw_draw_single_prim

The aperture rollback has been in place since

commit 3d851ae48865ac6a20a615e6e06d913c2265cda5
Author: Eric Anholt <eric at anholt.net>
Date:   Sat Oct 22 09:37:57 2011 -0700

    i965: Use the batch save/reset code to avoid needing the BO validate step.

7.10-branchpoint-6137-g3d851a!

The issue with believing global state for urb in particular seems to be from

commit d5e217dbfda2a87e149bdc8586c25143fc0ac183
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Fri Aug 18 16:10:39 2017 -0700

    i965: Stop looking at NewDriverState when emitting 3DSTATE_URB

I'm not sure if that's the only instance.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20180526/f5ebf97d/attachment.html>