[Bug 108630] [G965] piglit.spec.!opengl 1_2.tex3d-maxsize spins forever

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Nov 2 02:34:08 UTC 2018


Jordan Justen <jljusten at gmail.com> changed:

           What    |Removed                     |Added
                 CC|                            |kenneth at whitecape.org

--- Comment #3 from Jordan Justen <jljusten at gmail.com> ---

I found the issue. It is not specific to g965. In the blorp code, on a
retry, the check_aperture_failed_once variable will be reset back to
false since we clear things before the retry. This small patch added
to your change fixes it.

Another idea could be to preset check_aperture_failed_once before
the retry label.

Can you re-submit the patch with this, or a similar change?

diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c
index fd9ce93c6c..7b0f77af25 100644
--- a/src/mesa/drivers/dri/i965/genX_blorp_exec.c
+++ b/src/mesa/drivers/dri/i965/genX_blorp_exec.c
@@ -309,7 +309,7 @@ retry:
    intel_batchbuffer_require_space(brw, 1400);
    brw_require_statebuffer_space(brw, 600);
-   check_aperture_failed_once = intel_batchbuffer_saved_state_is_empty(brw);
+   check_aperture_failed_once |= intel_batchbuffer_saved_state_is_empty(brw);
    brw->batch.no_wrap = true;

 #if GEN_GEN == 6

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20181102/b514e1c9/attachment.html>

More information about the intel-3d-bugs mailing list