[Bug 91433] piglit.spec.arb_depth_buffer_float.fbo-depth-gl_depth_component32f-copypixels fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91433

--- Comment #8 from Nanley Chery <nanleychery at gmail.com> ---
(In reply to Illia from comment #5)
> (In reply to Nanley Chery from comment #4)
> 
> > I don't think we can delete pack_uint_Z_FLOAT32_X24S8 however, we need to
> > copy the S8 component of the buffer. I'm not sure why this test case still
> > works with your patch:
> > 
> > $ bin/fbo-depth copypixels GL_DEPTH32F_STENCIL8 -auto
> > 
> > Maybe we need to adjust the piglit test?
> 
> Test works correct. I've greped mesa and found only one mention  to
> "pack_uint_Z_FLOAT32_X24S8" there is in "_mesa_get_pack_uint_z_func" and
> I've edited its behavior. When  something calls 
> "_mesa_get_pack_uint_z_func" with "MESA_FORMAT_Z32_FLOAT_S8X24_UINT" it will
> get "pack_uint_Z_FLOAT32" it works like this in
> "_mesa_get_pack_float_z_func". 
> 

You're right. I think I understand how this function works now. It packs a
uint_Z value into a Z32_X24S8 and aims to leave the stencil component alone.
Sorry for the noise.

> I think we can  add comments to both functions if someone will look for  
> "pack_uint_Z_FLOAT32_X24S8" or "pack_float_Z_FLOAT32_X24S8".
> 
> > > I'm looking for a way  of not receiving this  message(Mesa 10.7.0-devel
> > > implementation error: Incorrectly writing swrast's integer depth values to
> > > MESA_FORMAT_Z_FLOAT32 depth buffer)
> > 
> > You can find the code which emits this error by grepping for part of the
> > message in the tree. I like using `git grep` personally.
> Thanks, I've found commit which implement sending this error.  It close
> related  with our bug. I think we can painless revert this commit. it's done
> its work.
> 
> commit fceff14450e48a90778e0d1e79c13fa7a40631e6
> Author: Eric Anholt <eric at anholt.net>
> 
>     mesa: Add a _mesa_problem to document a piglit failure on i965.
>     
>     Having figured out what was going on with piglit fbo-depth copypixels
>     GL_DEPTH_COMPONENT32...

Sounds good. I'll leave some comments on your v3.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20181004/72aedbd3/attachment.html>