[Bug 110305] Iris driver fails ext_packed_depth_stencil-getteximage test

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110305

            Bug ID: 110305
           Summary: Iris driver fails ext_packed_depth_stencil-getteximage
                    test
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/Iris
          Assignee: intel-3d-bugs at lists.freedesktop.org
          Reporter: andrey.simiklit at gmail.com
        QA Contact: intel-3d-bugs at lists.freedesktop.org

It fails on a FLOAT_32_UNSIGNED_INT_24_8_REV format
Stencil values which were recorded by a glTexImage2D are not
equal to the stencil values which were received by a glGetTexImage
https://gitlab.freedesktop.org/mesa/piglit/blob/master/tests/spec/ext_packed_depth_stencil/getteximage.c#L131

The result examples for a 8-bit stencil:
i965:
+--------------------+-----------+
|Expected pixel value|Pixel value|
+--------------------+-----------+
|     0x000000a3     | 0x000000a3|
|     0x000000a2     | 0x000000a2|
|     0x000000a1     | 0x000000a1|
|     0x000000a0     | 0x000000a0|
|     0x0000009f     | 0x0000009f|
|     0x0000009e     | 0x0000009e|
+--------------------+-----------+

iris:
+--------------------+-----------+
|Expected pixel value|Pixel value|
+--------------------+-----------+
|     0x000000a3     | 0x000055a3|
|     0x000000a2     | 0x000055a2|
|     0x000000a1     | 0x000000a1|
|     0x000000a0     | 0x000000a0|
|     0x0000009f     | 0x3ec2c29f|
|     0x0000009e     | 0x3ec6c69e|
+--------------------+-----------+

Note: gallium doesn't clean an unused space here (but I guess that it is an
expected behavior):
https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/gallium/auxiliary/util/u_transfer_helper.c#L276-301

Actually I guess that it is rather a piglit test issue because spec saying
about FLOAT_32_UNSIGNED_INT_24_8_REV the following:

+---------------+------------+---+
| 1st component |   Unused   |2nd|
+---------------+------------+---+
     32-bit        24-bit     8-bit

I actually guess that "unused" means that there is no guarantee that it
must be clean but I am not sure whether it enough for mesa or I should find
some more strict wording about it.

So possible piglit test fix is:
   -if (buf[i*2+1] != tex[i*2+1]) {
   +if ((buf[i*2+1] & 0xffu) != tex[i*2+1]) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20190402/cdf7ae96/attachment-0001.html>