[Bug 110344] Performance regression in mpv

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110344

--- Comment #5 from Denis <denys.kostin at globallogic.com> ---
hi again. If Drops is the main degradation trigger for now, so, I think, below
information may help.

In my case (in compare with your's, Nicolas), in old mesa versions I had about
50-60 drops, and 19+ mesa - 120+ drops. So I desided to bisect between.
Providing full bisect logs with "dropps" on each commit:

den at den-HP-ZBook-14u-G4:~/repositories/mesa$ git bisect log
git bisect start

    good: [190a79f462710f04d67eaefe498ef6ae5b7f5b1a] docs: add release notes
for 18.3.3
    git bisect good 190a79f462710f04d67eaefe498ef6ae5b7f5b1a
    Dropped: 52

    bad: [5925a5725831b22a92f4597388d1081126d8bc91] docs: Add release notes for
19.0.0
    git bisect bad 5925a5725831b22a92f4597388d1081126d8bc91
    Dropped: 130

    good: [1f41104b9bab50652050bf4524f2b9f371f7ca9b] meson: don't install
translation files
    git bisect good 1f41104b9bab50652050bf4524f2b9f371f7ca9b
    Dropped: 52

    good: [e890aaabed777e7c7736a519e94aef648081bd1d] travis: meson: add unwind
handling
    git bisect good e890aaabed777e7c7736a519e94aef648081bd1d
    Dropped: 62

    good: [5486c9d526f393eff4b189e0e0a44eafeedf4407] freedreno/a6xx: Turn on
texture tiling by default
    git bisect good 5486c9d526f393eff4b189e0e0a44eafeedf4407
    Dropped: 64

    good: [41a0acd6a149ec9f47ea527ad08a2b29bf1ee6b2] Switch imx to kmsro and
remove the imx winsys
    git bisect good 41a0acd6a149ec9f47ea527ad08a2b29bf1ee6b2
    Dropped: 52

    bad: [fb3485bc9248a12f47b07b593f0a81d58cbb3155] gallium/u_threaded: fix
EXPLICIT_FLUSH for flush offsets > 0
    git bisect bad fb3485bc9248a12f47b07b593f0a81d58cbb3155
    Dropped: 111

    bad: [82365595e9b4d947f1bdeec2b2eff1cdb226de5a] automake: Add float64.glsl
to dist tarball
    git bisect bad 82365595e9b4d947f1bdeec2b2eff1cdb226de5a
    Dropped: 112

    good: [7f1cf046cd1fb8a3af0e24b622179e4adb398764] intel/fs: Add a generic
SEND opcode
    git bisect good 7f1cf046cd1fb8a3af0e24b622179e4adb398764
    Dropped: 51

    good: [014edff0d20d52191570a4cb125c37b63955d664] intel/fs: Add interference
between SENDS sources
    git bisect good 014edff0d20d52191570a4cb125c37b63955d664
    Dropped: 51

    bad: [bcefa0f1cb99229b6dc241ff50b2c88da1dad950] freedreno: fix invalidate
logic
    git bisect bad bcefa0f1cb99229b6dc241ff50b2c88da1dad950
    Dropped: 115

    bad: [820dfcea431e4f96f25e6b340edd9cd1e449158b] egl/wayland-drm: Only
announce formats via wl_drm which the driver supports.
    git bisect bad 820dfcea431e4f96f25e6b340edd9cd1e449158b
    Dropped: 117

    bad: [a34b0d68bbf8571e4d858cf4e1176766a50364de] egl/wayland: Allow
client->server format conversion for PRIME offload. (v2)
    git bisect bad a34b0d68bbf8571e4d858cf4e1176766a50364de
    Dropped: 118

    bad: [a920979d4f30a48a23f8ff375ce05fa8a947dd96] intel/fs: Use split sends
for surface writes on gen9+
    git bisect bad a920979d4f30a48a23f8ff375ce05fa8a947dd96
    Dropped: 117

    first bad commit: [a920979d4f30a48a23f8ff375ce05fa8a947dd96] intel/fs: Use
split sends for surface writes on gen9+

____

commit a920979d4f30a48a23f8ff375ce05fa8a947dd96
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Fri Nov 16 10:46:27 2018 -0600

    intel/fs: Use split sends for surface writes on gen9+

    Surface reads don't need them because they just have the one address
    payload.  With surface writes, on the other hand, we can put the address
    and the data in the different halves and avoid building the payload all
    together.

    The decrease in register pressure and added freedom in register
    allocation resulting from this change reduces spilling enough to improve
    the performance of one customer benchmark by about 2x.

    Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20190410/312743c1/attachment-0001.html>