[Bug 111306] gbm creates BO with wrong pitch when dri3_get_modifiers returns modifiers, causing drmModeAddFB2WithModifiers to fail

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=111306

--- Comment #13 from Hans de Goede <jwrdegoede at fedoraproject.org> ---
Ok, so I added the following to my xserver:

diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
b/hw/xfree86/drivers/modesetting/drmmode_display.c
index e0d7cfb5c..c0c0d309b 100644
--- a/hw/xfree86/drivers/modesetting/drmmode_display.c
+++ b/hw/xfree86/drivers/modesetting/drmmode_display.c
@@ -985,6 +985,7 @@ drmmode_bo_import(drmmode_ptr drmmode, drmmode_bo *bo,
                 strides[i] = gbm_bo_get_stride_for_plane(bo->gbm, i);
                 offsets[i] = gbm_bo_get_offset(bo->gbm, i);
                 modifiers[i] = gbm_bo_get_modifier(bo->gbm);
+                ErrorF("modifier %d %llx\n", i, modifiers[i]);
             }

             return drmModeAddFB2WithModifiers(drmmode->fd, bo->width,
bo->height,

And this prints:

[  2127.597] modifier 0 100000000000004
[  2127.597] modifier 1 100000000000004
[  2127.597] (WW) modeset(0): Present-flip: Page flip failed: Invalid argument

With 100000000000004 (hex) corresponding to I915_FORMAT_MOD_Y_TILED_CCS

Note I'm running gnome-shell on top of Xorg, that may be part of what is
triggering this. I'm currently running mutter + gnome-shell master, but IIRC I
could also reproduce this while running plain 3.32 of both.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20190808/40527979/attachment.html>