[Bug 109442] "make check" test anv_block_pool_no_free fails intermittently

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Feb 7 15:35:34 UTC 2019


Jason Ekstrand <jason at jlekstrand.net> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jason Ekstrand <jason at jlekstrand.net> ---
Yup, It was fixed by

commit f2ece26601adda221ce5ae69c984f8b79a9cb0d0
Author: Rafael Antognolli <rafael.antognolli at intel.com>
Date:   Wed Jan 23 12:36:39 2019 -0800

    anv/allocator: Avoid race condition in anv_block_pool_map.

    Accessing bo->map and then pool->center_bo_offset without a lock is
    racy. One way of avoiding such race condition is to store the bo->map +
    center_bo_offset into pool->map at the time the block pool is growing,
    which happens within a lock.

    v2: Only set pool->map if not using softpin (Jason).
    v3: Move things around and only update center_bo_offset if not using
    softpin too (Jason).

    Cc: Jason Ekstrand <jason at jlekstrand.net>
    Reported-by: Ian Romanick <idr at freedesktop.org>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109442
    Fixes: fc3f58832015cbb177179e7f3420d3611479b4a9
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

We just forgot to close the bug.

You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20190207/9096df4f/attachment.html>

More information about the intel-3d-bugs mailing list