[Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=109532

--- Comment #48 from asimiklit <andrey.simiklit at gmail.com> ---
(In reply to Mark Janes from comment #46)
> I confirmed that the cross file is overriding our 32 bit flags that we pass
> through the environment.

(In reply to Dylan Baker from comment #47)
> Created attachment 143478 [details]
> attachment-11105-0.html
> 
> It's not that the cross file is overriding, CFLAGS and friends are for
> native (build) targets, not cross (host) targets.
> 
> I'm on mobile, please excuse autocorrect fail.
> 
> On Tue, Feb 26, 2019, 09:33 <bugzilla-daemon at freedesktop.org> wrote:
> 
> > *Comment # 46 <https://bugs.freedesktop.org/show_bug.cgi?id=109532#c46> on
> > bug 109532 <https://bugs.freedesktop.org/show_bug.cgi?id=109532> from Mark
> > Janes <mark.a.janes at intel.com> *
> >
> > I confirmed that the cross file is overriding our 32 bit flags that we pass
> > through the environment.
> >
> > ------------------------------
> > You are receiving this mail because:
> >
> >    - You are on the CC list for the bug.
> >
> >

To be 100% sure what going on with the DEBUG and NDEBUG macros I suggest to
build a following branch:
https://gitlab.freedesktop.org/asimiklit/mesa/tree/check_if_DEBUG_enabled
This branch contains following commit:
     void
    validate_ir_tree(exec_list *instructions)
    {
   +#ifdef DEBUG
   +   hmm_DEBUG_MACRO_is_defined = 1;
   +#else
   +   hmm_DEBUG_MACRO_is_NOT_defined = 1;
   +#endif
   +
   +#ifdef NDEBUG
   +   hmm_NDEBUG_is_defined_so_asserts_are_disabled = 1;
   +#else
   +   hmm_NDEBUG_is_NOT_defined_so_asserts_are_enabled = 1;
   +#endif

It should just produce compiling errors.
But depends on a error message we could understand which macros are defined :-)

Actually I tried to run it here:
https://mesa-ci.01.org/global_logic/builds/89/group/63a9f0ea7bb98050796b649e85481845

But I don't have an ability to see compiler error message because there is
displayed just that and just for m64:

stdout:
Command '['make', '-j', '18']' returned non-zero exit status 2

stderr:
NULL

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20190227/df73abc3/attachment.html>