[Bug 109317] piglit.spec.glsl-1_20.execution.out-parameter-indexing.fs-inout-index-two-level:

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=109317

            Bug ID: 109317
           Summary: piglit.spec.glsl-1_20.execution.out-parameter-indexing
                    .fs-inout-index-two-level:
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/i965
          Assignee: mattst88 at gmail.com
          Reporter: mark.a.janes at intel.com
        QA Contact: intel-3d-bugs at lists.freedesktop.org
                CC: t_arceri at yahoo.com.au

/tmp/build_root/m64/lib/piglit/bin/shader_runner
/tmp/build_root/m64/lib/piglit/tests/spec/glsl-1.20/execution/out-parameter-indexing/fs-inout-index-two-level.shader_test
-auto -fbo
Probe color at (0,0)
  Expected: 0 255 0 255
  Observed: 255 51 0 0
Test failure on line 48

-----------------------------------------------------------------
Bisected to:
76c27e47b90647df047e785d6b3ab5d0d979a1ee
Author:     Timothy Arceri <tarceri at itsqueeze.com>

glsl: Copy function out to temp if we don't directly ref a variable

Otherwise we can end up with IR that looks like this:

    (
      (declare (temporary ) vec4 f at 8)
      (assign  (xyzw) (var_ref f at 8)  (var_ref f) )
      (call f16  ((swiz y (var_ref f at 8) )))

      (assign  (xyzw) (var_ref f)  (var_ref f at 8) )
    ))

When we really need:

      (declare (temporary ) float inout_tmp)
      (assign  (x) (var_ref inout_tmp)  (swiz y (var_ref f) ))
      (call f16  ((var_ref inout_tmp) ))

      (assign  (y) (var_ref f)  (swiz y (swiz xxxx (var_ref inout_tmp) )))
      (declare (temporary ) void void_var)

The GLSL IR function inlining code seemed to produce correct code
even without this but we need the correct IR for GLSL IR -> NIR to
be able to understand whats going on.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20190111/2d5cddd2/attachment.html>