[Bug 110953] Adding a redundant single-iteration do-while loop causes different image to be rendered
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Tue Jun 25 18:41:38 UTC 2019
https://bugs.freedesktop.org/show_bug.cgi?id=110953
Ian Romanick <idr at freedesktop.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Ian Romanick <idr at freedesktop.org> ---
Fixed by:
commit ee1c69faddb3624ace6548dafaff50549a031380
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Thu Jun 20 15:48:48 2019 -0700
glsl: Don't increase the iteration count when there are no terminators
Incrementing the iteration count was intended to fix an off-by-one error
when the first terminator was superseded by a later terminator. If
there is no first terminator or later terminator, there is no off-by-one
error. Incrementing the loop count creates one. This can be seen in
loops like:
do {
if (something) {
// No breaks or continues here.
}
} while (false);
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Tested-by: Abel Briggs <abelbriggs1 at hotmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110953
Fixes: 646621c66da ("glsl: make loop unrolling more like the nir unrolling
path")
--
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20190625/3c8bed1f/attachment.html>
More information about the intel-3d-bugs
mailing list