[Bug 111405] Some infinite 'do{}while' loops lead mesa to an infinite compilation
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri Sep 6 23:40:53 UTC 2019
https://bugs.freedesktop.org/show_bug.cgi?id=111405
Jason Ekstrand <jason at jlekstrand.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #6 from Jason Ekstrand <jason at jlekstrand.net> ---
Fixed by the following commit now in master:
commit c832820ce959ae7c2b4971befceae634d800330f (HEAD -> master, origin/master,
origin/HEAD)
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Aug 30 11:35:26 2019 -0500
nir/dead_cf: Repair SSA if the pass makes progress
The dead_cf pass calls into the CF manipulation helpers which attempt to
keep NIR's SSA form sane. However, when the only break is removed from
a loop, dominance gets messed up anyway because the CF SSA clean-up code
only looks at phis and doesn't consider the case of code becoming
unreachable. One solution to this would be to put the loop into LCSSA
form before we modify any of its contents. Another (and the approach
taken by this pass) is to just run the repair_ssa pass afterwards
because the CF manipulation helpers are smart enough to keep all the
use/def stuff sane; they just don't always preserve dominance
properties.
While we're here, we clean up some bogus indentation.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111405
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111069
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20190906/348f5f3a/attachment.html>
More information about the intel-3d-bugs
mailing list