<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:mattst88@gmail.com" title="Matt Turner <mattst88@gmail.com>"> <span class="fn">Matt Turner</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [HSW][regression][bisect] RPG Maker game gives "invalid floating point operation" at startup"
href="https://bugs.freedesktop.org/show_bug.cgi?id=95419">bug 95419</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>REOPENED
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [HSW][regression][bisect] RPG Maker game gives "invalid floating point operation" at startup"
href="https://bugs.freedesktop.org/show_bug.cgi?id=95419#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [HSW][regression][bisect] RPG Maker game gives "invalid floating point operation" at startup"
href="https://bugs.freedesktop.org/show_bug.cgi?id=95419">bug 95419</a>
from <span class="vcard"><a class="email" href="mailto:mattst88@gmail.com" title="Matt Turner <mattst88@gmail.com>"> <span class="fn">Matt Turner</span></a>
</span></b>
<pre>(In reply to dnord from <a href="show_bug.cgi?id=95419#c14">comment #14</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=123926" name="attach_123926" title="patch3">attachment 123926</a> <a href="attachment.cgi?id=123926&action=edit" title="patch3">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=95419&attachment=123926'>[review]</a> [review]
> patch3
>
> Unfortunately I had not been able to reproduce any broken piglet tests,
> which were mentioned, introduced by this patch (obviously I tested only on
> my hardware, but piglet results were equal). Anyway I propose two patches,
> which solve this bug. First is not using any floating point arithmetic, just
> integer division, which is equal to rounding down and therefore should not
> allocate more chunks than available. Second is straightforward obvious fix
> to the original code - checking for null before two divisions.</span >
Thank you. I've tested and committed this version of the patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>