<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - 4.5% perf drop in CSDof with "nir: Optimize integer division and modulus with 1""
href="https://bugs.freedesktop.org/show_bug.cgi?id=98409#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - 4.5% perf drop in CSDof with "nir: Optimize integer division and modulus with 1""
href="https://bugs.freedesktop.org/show_bug.cgi?id=98409">bug 98409</a>
from <span class="vcard"><a class="email" href="mailto:eero.t.tamminen@intel.com" title="Eero Tamminen <eero.t.tamminen@intel.com>"> <span class="fn">Eero Tamminen</span></a>
</span></b>
<pre>(In reply to Jordan Justen from <a href="show_bug.cgi?id=98409#c5">comment #5</a>)
<span class="quote">> When reverting:
>
> 4d35683 nir: Optimize integer division and modulus with 1
>
> Did you also revert these?</span >
No.
<span class="quote">> 64c3d73 i965/cs: Don't use a thread channel ID for small local sizes
> 1fa000a i965/cs: Use udiv/umod for local IDs
>
> It would be good to know if taking the current master, and
> reverting these 3 patches regains the 4-5%.</span >
Tried that now.
If one builds commit 4d35683, reverting just that commit fixes the drop. With
HEAD, that's not enough, but reverting all 3 patches does fix the drop there
too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>