<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - dEQP mandates preprocessor tests for define defined"
href="https://bugs.freedesktop.org/show_bug.cgi?id=98522#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - dEQP mandates preprocessor tests for define defined"
href="https://bugs.freedesktop.org/show_bug.cgi?id=98522">bug 98522</a>
from <span class="vcard"><a class="email" href="mailto:idr@freedesktop.org" title="Ian Romanick <idr@freedesktop.org>"> <span class="fn">Ian Romanick</span></a>
</span></b>
<pre>I think <a href="https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15567#c22">https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15567#c22</a> matches what
dEQP expects. Basically, C explicitly allows
#define derp defined
According to <a href="https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15567#c21">https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15567#c21</a>, C says
that the following is undefined, but c22 says that all tested C compiler "do
the right thing":
#if derp herp
Just from peeking over Ken's shoulder, I think this is the behavior that dEQP
expects. As far as I'm aware, WebGL expects errors for this, but GLSL ES and
desktop GLSL have left it also undefined.
I think we should accept these, but we should probably generate warnings. I
think the warning should occur in the #if line. I believe this is what glslang
does in its permissive mode.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>