<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - piglit.spec.arb_shader_subroutine.compiler.direct-call_vert regression"
href="https://bugs.freedesktop.org/show_bug.cgi?id=100026">100026</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>piglit.spec.arb_shader_subroutine.compiler.direct-call_vert regression
</td>
</tr>
<tr>
<th>Product</th>
<td>Mesa
</td>
</tr>
<tr>
<th>Version</th>
<td>git
</td>
</tr>
<tr>
<th>Hardware</th>
<td>x86-64 (AMD64)
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux (All)
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>major
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>Drivers/DRI/i965
</td>
</tr>
<tr>
<th>Assignee</th>
<td>samuel.pitoiset@gmail.com
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mark.a.janes@intel.com
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>intel-3d-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>CC</th>
<td>t_arceri@yahoo.com.au
</td>
</tr></table>
<p>
<div>
<pre>bisected to:
be8aa76afd2cc5326c9d9d59c591e06365c5f618
Author: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a>>
glsl: remove unecessary flags.q.subroutine_def
This bit is definitely not necessary because subroutine_list
can be used instead. This frees one more bit in the flags.q
struct which is nice because arb_bindless_texture will need
4 bits for the new layout qualifiers.
No piglit regressions found (including compiler tests) with
"-t subroutine".
v2: set the subroutine flag for validating illegal flags
Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a>>
Reviewed-by: Timothy Arceri <<a href="mailto:tarceri@itsqueeze.com">tarceri@itsqueeze.com</a>>
Standard Output:
/tmp/build_root/m64/lib/piglit/bin/glslparsertest
/tmp/build_root/m64/lib/piglit/tests/spec/arb_shader_subroutine/compiler/direct-call.vert
pass 1.50 GL_ARB_shader_subroutine
piglit: debug: Requested an OpenGL 3.2 Core Context, and received a matching
4.5 context
Shader source:
// [config]
// expect_result: pass
// glsl_version: 1.50
// require_extensions: GL_ARB_shader_subroutine
// [end config]
#version 150
#extension GL_ARB_shader_subroutine: require
/* The ARB_shader_subroutine spec says nothing to
* explicitly disallow calling subroutine implementations
* as normal functions.
*
* It seems reasonable that this would still work.
*/
subroutine void func_type();
/* A subroutine matching the above type */
subroutine (func_type) void impl() {}
/* Call the function directly, rather than via
* a subroutine uniform.
*/
void foo() {
impl();
}
Standard Error
Failed to compile vertex shader
/tmp/build_root/m64/lib/piglit/tests/spec/arb_shader_subroutine/compiler/direct-call.vert:
0:26(2): error: subroutine name cannot be a constructor `impl'</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>