<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [HSW] assertion in piglit.gl45-cts.arrays_of_arrays_gl.interactionargumentaliasing" href="https://bugs.freedesktop.org/show_bug.cgi?id=99603#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [HSW] assertion in piglit.gl45-cts.arrays_of_arrays_gl.interactionargumentaliasing" href="https://bugs.freedesktop.org/show_bug.cgi?id=99603">bug 99603</a> from <a class="email" href="mailto:t_arceri@yahoo.com.au" title="Timothy Arceri <t_arceri@yahoo.com.au>"> Timothy Arceri</a> <pre>This should not block the release, it doesn't change anything in a release build. The asserts were wrong this change just fixes them, the tests just happened to pass previously and that will not have changed in a release build after this. The problem is the loop is too large and if I recall correctly that was because these tests contain a large switch statement which gets wrapped in a loop that can never be unrolled since the work around in this commit: commit 73dd50acf6d244979c2a657906aa56d3ac60d550 Author: Tapani Pälli <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>> Date: Wed Aug 6 09:46:54 2014 +0300 glsl: implement switch flow control using a loop Patch removes old variable based logic for handling a break inside switch. Switch is put inside a loop so that existing infrastructure for loop flow control can be used for the switch, now also dead code elimination works properly. Possible 'continue' call inside a switch needs now special handling which is taken care of by detecting continue, breaking out and calling continue for the outside loop. v2: remove one unnecessary ir_expression (Curro) Fixes following Piglit tests: fs-exec-after-break.shader_test fs-conditional-break.shader_test No Piglit or es3conform regressions. Signed-off-by: Tapani Pälli <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>> Reviewed-by: Francisco Jerez <<a href="mailto:currojerez@riseup.net">currojerez@riseup.net</a>></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>