<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - assertion failure in ir_validate.cpp:240" href="https://bugs.freedesktop.org/show_bug.cgi?id=102274#c1">Comment # 1</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - assertion failure in ir_validate.cpp:240" href="https://bugs.freedesktop.org/show_bug.cgi?id=102274">bug 102274</a> from <a class="email" href="mailto:brianp@vmware.com" title="Brian Paul <brianp@vmware.com>"> Brian Paul</a> <pre>I bisected the regression to this commit: commit e2e2c5abd279df1b3aa99c52b81c9cb48fea35fb Author: Timothy Arceri <<a href="mailto:tarceri@itsqueeze.com">tarceri@itsqueeze.com</a>> Date: Wed Aug 9 13:34:02 2017 +1000 glsl: calculate number of operands in an expression once Extra validation is added to ir_validate to make sure this is always updated to the correct numer of operands, as passes like lower_instructions modify the instructions directly rather then generating a new one. The reduction in time is so small that it is not really measurable. However callgrind was reporting this function as being called just under 34 million times while compiling the Deus Ex shaders (just pre-linking was profiled) with 0.20% spent in this function. v2: - make num_operands a unit8_t - fix unsigned/signed mismatches Reviewed-by: Thomas Helland <<a href="mailto:thomashelland90@gmail.com">thomashelland90@gmail.com</a>></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>