<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:kenneth@whitecape.org" title="Kenneth Graunke <kenneth@whitecape.org>"> <span class="fn">Kenneth Graunke</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - i965: dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 takes 3m22s to compile"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103322">bug 103322</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>mattst88@gmail.com
</td>
<td>kenneth@whitecape.org
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>ASSIGNED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - i965: dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 takes 3m22s to compile"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103322#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - i965: dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23 takes 3m22s to compile"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103322">bug 103322</a>
from <span class="vcard"><a class="email" href="mailto:kenneth@whitecape.org" title="Kenneth Graunke <kenneth@whitecape.org>"> <span class="fn">Kenneth Graunke</span></a>
</span></b>
<pre>Oh, I think there's actually a simple fix here.
The issue is that add_barrier_dep sets is_barrier = true, and walks backward to
the previous barrier, and forward to...the end of the program...because if
you're walking forward, you haven't set is_barrier on any future instructions
yet.
I think we just need to change to is_scheduling_barrier() instead, which means
moving some things to backend_instruction instead of fs_inst. (I have a vague
memory that Curro wanted us to do that in the first place...)
I've got a patch to do that, and it reduces the runtime to 3.6 seconds. The
test still passes, but I'll have to do real regression testing and clean it up
tomorrow.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>