<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [OpenGL CTS] KHR-GL45.enhanced_layouts.varying_structure_locations fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=103098#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [OpenGL CTS] KHR-GL45.enhanced_layouts.varying_structure_locations fails" href="https://bugs.freedesktop.org/show_bug.cgi?id=103098">bug 103098</a> from <a class="email" href="mailto:imirkin@alum.mit.edu" title="Ilia Mirkin <imirkin@alum.mit.edu>"> Ilia Mirkin</a> <pre>Hmmm... well, I had left a TODO of refactoring get_varying_type, which I copied from somewhere. Also, TBH, I have some recollection of it breaking something else. Oh right -- so with like a TCS input, "vec4 foo[32]", are we supposed to just have a "foo" resource or a "foo[0]" resource (and/or a "foo[1]" resource? I think that tripped me up last (and some tests were failing as a result). Did you run that (second) patch through a full test run that includes dEQP? Either way, feel free to send it out with fixes or whatever. Like Ken mentioned, I'm out of time to work on this.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>