<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - 10% perf drop in CPU bound tests with "i965: Call gen6_upload_push_constants() even when the stage is disabled""
href="https://bugs.freedesktop.org/show_bug.cgi?id=103517#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - 10% perf drop in CPU bound tests with "i965: Call gen6_upload_push_constants() even when the stage is disabled""
href="https://bugs.freedesktop.org/show_bug.cgi?id=103517">bug 103517</a>
from <span class="vcard"><a class="email" href="mailto:eero.t.tamminen@intel.com" title="Eero Tamminen <eero.t.tamminen@intel.com>"> <span class="fn">Eero Tamminen</span></a>
</span></b>
<pre>According to ezBench:
* Indicated commit also broke Xonotic rendering, in addition to performance
regression
* This commit fixed the rendering issue, but not the performance drop:
---------------------------------------------------------
commit 877dd14e88de6ee115617a2a6412e86ba67db443
Author: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>>
AuthorDate: Fri Oct 20 15:38:52 2017 -0700
Commit: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>>
CommitDate: Mon Oct 30 20:38:08 2017 -0700
i965: Don't flag BRW_NEW_SURFACES unless some push constants are dirty.
Due to a gaffe on my part, we were re-emitting all binding table entries
on every single draw call. The push_constant_packets atom listens to
BRW_NEW_DRAW_CALL, but skips emitting 3DSTATE_CONSTANT_XS for each stage
unless stage_state->push_constants_dirty is true. However, it flagged
BRW_NEW_SURFACES unconditionally at the end, by mistake.
Instead, it should only flag it if we actually emit 3DSTATE_CONSTANT_XS
for a stage. We can move it a few lines up, inside the loop - the early
continues will skip over it if push constants aren't dirty for a stage.
With INTEL_NO_HW=1 set, improves performance of GFXBench5 gl_driver_2
on Apollolake at 1280x720 by 1.01122% +/- 0.470723% (n=35).
Reviewed-by: Rafael Antognolli <<a href="mailto:rafael.antognolli@intel.com">rafael.antognolli@intel.com</a>>
---------------------------------------------------------
(And indeed, the perf is still at the regressed level, it hasn't improved
noticeably since the regression.)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>