<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [i965 bisected] commit 6ee4b352c90e93c82d900328716c1068a7188b91 regress ASTROKILL and EVERSPACE on Haswell" href="https://bugs.freedesktop.org/show_bug.cgi?id=103632#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [i965 bisected] commit 6ee4b352c90e93c82d900328716c1068a7188b91 regress ASTROKILL and EVERSPACE on Haswell" href="https://bugs.freedesktop.org/show_bug.cgi?id=103632">bug 103632</a> from <a class="email" href="mailto:d.spitznagel@goodbytez.de" title="Darius Spitznagel <d.spitznagel@goodbytez.de>"> Darius Spitznagel</a> <pre>(In reply to Matt Turner from <a href="show_bug.cgi?id=103632#c2">comment #2</a>) > Could you do us a huge favor and bisect the fix? > > I'm surprised to hear it's fixed. There's nothing in the commit log that > indicates anyone has investigated the bug. I'm glad to help Matt... 4cf6b9e7ed8a962f50b5e89ae36d6b7f3a92b96e is the first fixed commit commit 4cf6b9e7ed8a962f50b5e89ae36d6b7f3a92b96e Author: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> Date: Tue Oct 31 00:56:24 2017 -0700 i965: properly initialize brw->cs.base.stage to MESA_SHADER_COMPUTE This has a bit of a surprising effect: For the render pipeline, the upload_sampler_state_table atom emits 3DSTATE_BINDING_TABLE_POINTERS_XS. It tries to avoid this for compute: if (GEN_GEN >= 7 && stage_state->stage != MESA_SHADER_COMPUTE) { /* Emit a 3DSTATE_SAMPLER_STATE_POINTERS_XS packet. */ genX(emit_sampler_state_pointers_xs)(brw, stage_state); } ... However, we were failing to initialize brw->cs.base.stage, so it was left as 0 (MESA_SHADER_VERTEX), causing this condition to break. We then emitted 3DSTATE_SAMPLER_STATE_POINTERS_VS in GPGPU mode, when trying to upload CS samplers. Nothing good can come of this. Found by inspection while debugging a GPU hang. Jordan believes this helps the Deus Ex: Mankind Divided benchmark mode's stability when running with shader cache. Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a> Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> Reviewed-by: Jordan Justen <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>> (cherry picked from commit a16dc04ad51c32e5c7d136e4dd6273d983385d3f) :040000 040000 84b0b8b9d018cebba864022ac039a00923dd4cb7 2e21e6e28301fafab7bb35f10ebc833864d1d656 M src</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>