<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:kenneth@whitecape.org" title="Kenneth Graunke <kenneth@whitecape.org>"> <span class="fn">Kenneth Graunke</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [i965 bisected] commit 6ee4b352c90e93c82d900328716c1068a7188b91 regress ASTROKILL and EVERSPACE on Haswell"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103632">bug 103632</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [i965 bisected] commit 6ee4b352c90e93c82d900328716c1068a7188b91 regress ASTROKILL and EVERSPACE on Haswell"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103632#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [i965 bisected] commit 6ee4b352c90e93c82d900328716c1068a7188b91 regress ASTROKILL and EVERSPACE on Haswell"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103632">bug 103632</a>
from <span class="vcard"><a class="email" href="mailto:kenneth@whitecape.org" title="Kenneth Graunke <kenneth@whitecape.org>"> <span class="fn">Kenneth Graunke</span></a>
</span></b>
<pre>Thanks for tracking that down, Darius! Apparently there was a pretty nasty
bug...the L3 config code was doing:
const struct gl_program *prog =
brw->ctx._Shader->CurrentProgram[stage_states[i]->stage];
but because we'd failed to set brw->cs.stage = MESA_SHADER_COMPUTE, it was
initialized to 0 aka MESA_SHADER_VERTEX. So, when calculating the data cache
needs, prog_data properly pointed at the compute shader, but prog incorrectly
was the vertex shader.
That means Jason's commit (the one regressing things) caused us to start
considering the vertex shader's number of images rather than the compute
shader. That was probably near 0, so we thought we didn't need to bother
allocating any cache to DC. But, his patch was fine...and in fact, the bogus
prog had been around for quite a while. The real bug was the one I fixed.
While looking at this, I found another bug in the area, and sent a patch:
<a href="https://patchwork.freedesktop.org/patch/188561/">https://patchwork.freedesktop.org/patch/188561/</a>
Again, thanks for helping us catch these issues!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>