<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:mattst88@gmail.com" title="Matt Turner <mattst88@gmail.com>"> <span class="fn">Matt Turner</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Increased difference from reference image in shaders"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103616">bug 103616</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>ASSIGNED
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Increased difference from reference image in shaders"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103616#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Increased difference from reference image in shaders"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103616">bug 103616</a>
from <span class="vcard"><a class="email" href="mailto:mattst88@gmail.com" title="Matt Turner <mattst88@gmail.com>"> <span class="fn">Matt Turner</span></a>
</span></b>
<pre>Thanks again for the bug report and bisection!
Fixed by
commit a05af1f7b8f82a38513bba31f9573cd62d82f18d
Author: Matt Turner <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>>
Date: Mon Nov 20 14:24:57 2017 -0800
i965/fs: Handle negating immediates on MADs when propagating saturates
MADs don't take immediate sources, but we allow them in the IR since it
simplifies a lot of things. I neglected to consider that case.
Fixes: 4009a9ead490 ("i965/fs: Allow saturate propagation to propagate
negations into MADs.")
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Increased difference from reference image in shaders"
href="show_bug.cgi?id=103616">https://bugs.freedesktop.org/show_bug.cgi?id=103616</a>
Reported-and-Tested-by: Ruslan Kabatsayev <<a href="mailto:b7.10110111@gmail.com">b7.10110111@gmail.com</a>>
Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>>
and tested by
commit beaea7abfa9f25460284f739fa50050a889ce6cd
Author: Matt Turner <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>>
Date: Mon Nov 20 14:21:43 2017 -0800
i965/fs: Check ADD/MAD with immediates in satprop unit test
The gen had to be changed from 4 to 6 so that we could test MAD, which
is new on Gen6.
mad_imm_float_neg_mov_sat tests the case fixed by the previous commit.
Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>