<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:jasuarez@igalia.com" title="Juan A. Suarez <jasuarez@igalia.com>"> <span class="fn">Juan A. Suarez</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - KHR-GL46.enhanced_layouts.varying* regression"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103942">bug 103942</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - KHR-GL46.enhanced_layouts.varying* regression"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103942#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - KHR-GL46.enhanced_layouts.varying* regression"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103942">bug 103942</a>
from <span class="vcard"><a class="email" href="mailto:jasuarez@igalia.com" title="Juan A. Suarez <jasuarez@igalia.com>"> <span class="fn">Juan A. Suarez</span></a>
</span></b>
<pre>commit 6d540aa092d5d78dde643af40257444567bf7b95
Author: Juan A. Suarez Romero <<a href="mailto:jasuarez@igalia.com">jasuarez@igalia.com</a>>
Date: Wed Nov 29 12:09:47 2017 +0100
mesa: deal with vs_inputs as 64-bit unsigned integer
Commit 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits") uses
vs_prog_data->vs_inputs as if it were a 32-bit unsigned integer.
But actually it is a 64-bit integer, and as such it is used in other
parts of Mesa code. It is worth to note that bits from the entire range
are used, and not only 32-bits. This is due our implementation for
handling 64-bit dual-slot input attributes, which requires to use a
larger bitfield to manage them.
This commit reverts the changes done in brw_draw_upload.c, keeping the
rest of the changes.
This fixes the following tests:
- KHR-GL45.enhanced_layouts.varying_array_locations
- KHR-GL45.enhanced_layouts.varying_locations
Fixes: 78942e ("mesa: shrink VERT_ATTRIB bitfields to 32 bits")
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - KHR-GL46.enhanced_layouts.varying* regression"
href="show_bug.cgi?id=103942">https://bugs.freedesktop.org/show_bug.cgi?id=103942</a>
CC: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>>
CC: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>>
Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>>
Reviewed-by: Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>>
Signed-off-by: Juan A. Suarez Romero <<a href="mailto:jasuarez@igalia.com">jasuarez@igalia.com</a>>
src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>