<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:agomez@igalia.com" title="Andrés Gómez García <agomez@igalia.com>"> <span class="fn">Andrés Gómez García</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [OpenGL CTS] [HSW] KHR-GL45.vertex_attrib_binding.basic-inputL-case1"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103006">bug 103006</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [OpenGL CTS] [HSW] KHR-GL45.vertex_attrib_binding.basic-inputL-case1"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103006#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [OpenGL CTS] [HSW] KHR-GL45.vertex_attrib_binding.basic-inputL-case1"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103006">bug 103006</a>
from <span class="vcard"><a class="email" href="mailto:agomez@igalia.com" title="Andrés Gómez García <agomez@igalia.com>"> <span class="fn">Andrés Gómez García</span></a>
</span></b>
<pre>Fixed in master with:
commit 5a7aba2e0a7fb3414a94d04d5970a2ed10c1f63e
Author: Andres Gomez <<a href="mailto:agomez@igalia.com">agomez@igalia.com</a>>
Date: Mon Jan 29 18:25:30 2018 +0200
i965: perform 2 uploads with dual slot *64*PASSTHRU formats on gen<8
The emission of vertex attributes corresponding to dvec3 and dvec4
vertex shader input variables was not correct when the <size> passed
to the VertexAttribL* commands was <= 2.
In 61a8a55f557 ("i965/gen8: Fix vertex attrib upload for dvec3/4
shader inputs"), for gen8+ we needed to determine if the attrib was
dual slot to emit 128 or 256-bit, independently of the VAO size.
Similarly, for gen < 8 we also need to determine whether the attrib is
dual slot to force the emission of 256-bits through 2 uploads.
Additionally, we make use of the ISL_FORMAT_R32_FLOAT format in this
second upload to fill these unspecified components with zeros, as we
also do for gen8+.
Fixes the following test on Haswell:
KHR-GL46.vertex_attrib_binding.basic-inputL-case1
v2: Added more inline comments to explain why we are using
ISL_FORMAT_R32_FLOAT and its consequences, as requested by
Alejandro and Antía.
Fixes: 75968a668e4 ("i965/gen7: expose OpenGL 4.2 on Haswell when
supported")
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [OpenGL CTS] [HSW] KHR-GL45.vertex_attrib_binding.basic-inputL-case1"
href="show_bug.cgi?id=103006">https://bugs.freedesktop.org/show_bug.cgi?id=103006</a>
Cc: Alejandro Piñeiro <<a href="mailto:apinheiro@igalia.com">apinheiro@igalia.com</a>>
Cc: Juan A. Suarez Romero <<a href="mailto:jasuarez@igalia.com">jasuarez@igalia.com</a>>
Cc: Antia Puentes <<a href="mailto:apuentes@igalia.com">apuentes@igalia.com</a>>
Cc: Rafael Antognolli <<a href="mailto:rafael.antognolli@intel.com">rafael.antognolli@intel.com</a>>
Cc: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>>
Signed-off-by: Andres Gomez <<a href="mailto:agomez@igalia.com">agomez@igalia.com</a>>
Reviewed-by: Alejandro Piñeiro <<a href="mailto:apinheiro@igalia.com">apinheiro@igalia.com</a>>
Reviewed-by: Antia Puentes <<a href="mailto:apuentes@igalia.com">apuentes@igalia.com</a>>
Reviewed-by: Rafael Antognolli <<a href="mailto:rafael.antognolli@intel.com">rafael.antognolli@intel.com</a>>
Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>