<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:mark.a.janes@intel.com" title="Mark Janes <mark.a.janes@intel.com>"> <span class="fn">Mark Janes</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [m32] piglit regressions relinking program without shaders"
href="https://bugs.freedesktop.org/show_bug.cgi?id=105820">bug 105820</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEEDINFO
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [m32] piglit regressions relinking program without shaders"
href="https://bugs.freedesktop.org/show_bug.cgi?id=105820#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [m32] piglit regressions relinking program without shaders"
href="https://bugs.freedesktop.org/show_bug.cgi?id=105820">bug 105820</a>
from <span class="vcard"><a class="email" href="mailto:mark.a.janes@intel.com" title="Mark Janes <mark.a.janes@intel.com>"> <span class="fn">Mark Janes</span></a>
</span></b>
<pre>fixed by
6f6e711c721eba8dad1541479e31d5db5108b41d
Author: Dylan Baker <<a href="mailto:dylan@pnwbakers.com">dylan@pnwbakers.com</a>>
AuthorDate: Mon Apr 2 15:29:45 2018 -0700
Commit: Dylan Baker <<a href="mailto:dylan@pnwbakers.com">dylan@pnwbakers.com</a>>
CommitDate: Tue Apr 3 08:47:59 2018 -0700
Parent: d3e96b10630 radeonsi/gfx9: fix bad LLVM params in monolithic LS+HS
Containing: master
Follows: 17.3-branchpoint (4386)
mesa: ensure that variable is initialized
This variable controls whether we link using the glsl code path or the
spirv path. It's set when we validate that all shaders are glsl or
spirv, but if there are no shaders attached to the program it will
remain unset, resulting in undefined behavior. We want to go down the
glsl path in that case, so initialize to false.
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [m32] piglit regressions relinking program without shaders"
href="show_bug.cgi?id=105820">https://bugs.freedesktop.org/show_bug.cgi?id=105820</a>
Fixes: 16f6634e7fb5ada308e55b852cd49251e7f3f8b1
("mesa/program: Link SPIR-V shaders using the SPIR-V code-path")
Signed-off-by: Dylan Baker <<a href="mailto:dylan.c.baker@intel.com">dylan.c.baker@intel.com</a>>
Tested-by: Mark Janes <<a href="mailto:mark.a.janes@intel.com">mark.a.janes@intel.com</a>>
Reviewed-by: Alejandro Piñeiro <<a href="mailto:apinheiro@igalia.com">apinheiro@igalia.com</a>></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>