<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - The big SKQP bug" href="https://bugs.freedesktop.org/show_bug.cgi?id=105301#c34">Comment # 34</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - The big SKQP bug" href="https://bugs.freedesktop.org/show_bug.cgi?id=105301">bug 105301</a> from <a class="email" href="mailto:aditya.swarup@intel.com" title="Aditya Swarup <aditya.swarup@intel.com>"> Aditya Swarup</a> <pre>Also, tested patch in #16 for SRGBMipMaps unit test. It passes. :) @Ken Can you please pitch in for the debate regarding EGLImage test failure where the skia test is failing as we are creating EGLImage out of a 2D texture and then converting it to an external texture. It hits the following check in MESA in file intel_tex_image.c: In intel_image_target_texture_2d(): /* We support external textures only for EGLImages created with * EGL_EXT_image_dma_buf_import. We may lift that restriction in the future. */ if (target == GL_TEXTURE_EXTERNAL_OES && !image->dma_buf_imported) { _mesa_error(ctx, GL_INVALID_OPERATION, "glEGLImageTargetTexture2DOES(external target is enabled only " "for images created with EGL_EXT_image_dma_buf_import"); return; } Removing this check and the flag dma_buf_imported solves the problem. I have not submitted the patch upstream but uploaded it for chromium: <a href="https://chromium-review.googlesource.com/c/chromiumos/third_party/mesa/+/1285296">https://chromium-review.googlesource.com/c/chromiumos/third_party/mesa/+/1285296</a> I don't know the logic behind restricting external textures to be only created using dmabuf. Do you feel this can be accepted upstream or Skqp is doing illegal operation wrt external texture?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>