<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - [bisected] Failure in Piglit spec.ext_image_dma_buf_import.ext_image_dma_buf_import-intel_external_sampler_with_dma_only" href="https://bugs.freedesktop.org/show_bug.cgi?id=108701#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - [bisected] Failure in Piglit spec.ext_image_dma_buf_import.ext_image_dma_buf_import-intel_external_sampler_with_dma_only" href="https://bugs.freedesktop.org/show_bug.cgi?id=108701">bug 108701</a> from <a class="email" href="mailto:lionel.g.landwerlin@linux.intel.com" title="Lionel Landwerlin <lionel.g.landwerlin@linux.intel.com>"> Lionel Landwerlin</a> <pre>(In reply to Aditya Swarup from <a href="show_bug.cgi?id=108701#c5">comment #5</a>) > I still feel this test is important as it tests one of the corner cases wrt > EGLImages created using 2D textures and then converted to an external > texture. > > We shouldn't have deleted this test, rather renamed it and changed the > condition for this test to pass when we are using 2D tex to create EGLImages > and then treating it as an external texture. > > In fact, we lifted the restriction due to a similar test failing for Google > SKIA test suite - unitTest_EGLImageTest. This is a corner case and spec > doesn't specifically state this. > > But it is still useful to catch bugs in future if due to some change in > MESA, we are unable to create external textures from EGLImages with 2D tex. That's fair, I didn't really think about that. And it seems that we don't have any other test left in piglit actually exercising this. That being said, creating an EGLImage out of a 2D texture doesn't have much to do with the EGL_EXT_image_dma_buf_import extension. A quick look at the VK-GL-CTS repo shows that there are tests exercising that path (dEQP-EGL.functional.image.api.create_image_gles2_tex2d_rgba). Since we run both on the Mesa CI, I think that should get you covered. Thanks for the reminder!</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>