<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - [bisected] [HSW] Regression in clipping.user_defined.clip_* vulkancts tests" href="https://bugs.freedesktop.org/show_bug.cgi?id=109081#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - [bisected] [HSW] Regression in clipping.user_defined.clip_* vulkancts tests" href="https://bugs.freedesktop.org/show_bug.cgi?id=109081">bug 109081</a> from <a class="email" href="mailto:t_arceri@yahoo.com.au" title="Timothy Arceri <t_arceri@yahoo.com.au>"> Timothy Arceri</a> <pre>(In reply to Ian Romanick from <a href="show_bug.cgi?id=109081#c6">comment #6</a>) > (In reply to Timothy Arceri from <a href="show_bug.cgi?id=109081#c5">comment #5</a>) > > (In reply to Ian Romanick from <a href="show_bug.cgi?id=109081#c3">comment #3</a>) > > > I've submitted an MR for a possible fix for problem #2. > > > > > > <a href="https://gitlab.freedesktop.org/mesa/mesa/merge_requests/26">https://gitlab.freedesktop.org/mesa/mesa/merge_requests/26</a> > > > > > > I'm have an idea for problem #1, but I don't know that I'll get to it before > > > the new year. Maybe Tim will beat me to it. ;) > > > > The problem with peephole select is that we loose opportunities to apply the > > growing list of opts in nir_opt_if(). In this case we no longer recognise > > the pattern in opt_peel_loop_initial_if() > > I suspected it was something like that. I was planning to go through and > beef up the places that handle if-statements to also handle bcsel. That > doesn't (conceptually) seem to hard. What do you think? It should be fine for opt_peel_loop_initial_if() but for things like opt_if_evaluate_condition_use() and <a href="https://patchwork.freedesktop.org/patch/263442/">https://patchwork.freedesktop.org/patch/263442/</a> it's not really possible to do.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>