<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [BISECTED] [REGRESSION] KHR-GL45.enhanced_layouts.glsl_contant_immutablity aborts in second execution"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109405">109405</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[BISECTED] [REGRESSION] KHR-GL45.enhanced_layouts.glsl_contant_immutablity aborts in second execution
</td>
</tr>
<tr>
<th>Product</th>
<td>Mesa
</td>
</tr>
<tr>
<th>Version</th>
<td>git
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>glsl-compiler
</td>
</tr>
<tr>
<th>Assignee</th>
<td>mesa-dev@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>agomez@igalia.com
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>intel-3d-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>CC</th>
<td>t_arceri@yahoo.com.au
</td>
</tr></table>
<p>
<div>
<pre>After:
--
commit 64b8c86d37ebb1e1d286c69d642d52b7bcf051d3 (danger/master)
Author: Timothy Arceri <<a href="mailto:tarceri@itsqueeze.com">tarceri@itsqueeze.com</a>>
Date: Thu Jan 17 17:16:29 2019 +1100
glsl: be much more aggressive when skipping shader compilation
Currently we only add a cache key for a shader once it is linked.
However games like Team Fortress 2 compile a whole bunch of shaders
which are never actually linked. These compiled shaders can take
up a bunch of memory.
This patch changes things so that we add the key for the shader to
the cache as soon as it is compiled. This means on a warm cache we
can avoid the wasted memory from these shaders. Worst case scenario
is we need to compile the shaders at link time but this can happen
anyway if the shader has been evicted from the cache.
Reduces memory use in Team Fortress 2 from 1.3GB -> 770MB on a
warm cache from start up to the game menu.
Acked-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>>
--
The following VK-GL-CTS test is failing in a second execution with the i965
driver, shader cache activated, and the x11_egl target:
--
local@5207cd755898:~/vk-gl-cts/build/external/openglcts/modules$ ./glcts
--deqp-case="KHR-GL45.enhanced_layouts.glsl_contant_immutablity"
Writing test log into TestResults.qpa
dEQP Core git-117ce3699c7e2d3d04f1760b25399aedd5dc90fa (0x117ce369) starting..
target implementation = 'X11 EGL'
ATTENTION: default value of option vblank_mode overridden by environment.
Test case 'KHR-GL45.enhanced_layouts.glsl_contant_immutablity'..
Pass (Pass)
DONE!
Test run totals:
Passed: 1/1 (100.0%)
Failed: 0/1 (0.0%)
Not supported: 0/1 (0.0%)
Warnings: 0/1 (0.0%)
local@5207cd755898:~/vk-gl-cts/build/external/openglcts/modules$ ./glcts
--deqp-case="KHR-GL45.enhanced_layouts.glsl_contant_immutablity"
Writing test log into TestResults.qpa
dEQP Core git-117ce3699c7e2d3d04f1760b25399aedd5dc90fa (0x117ce369) starting..
target implementation = 'X11 EGL'
ATTENTION: default value of option vblank_mode overridden by environment.
Test case 'KHR-GL45.enhanced_layouts.glsl_contant_immutablity'..
Segmentation fault (core dumped)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>