<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:eero.t.tamminen@intel.com" title="Eero Tamminen <eero.t.tamminen@intel.com>"> <span class="fn">Eero Tamminen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_VERIFIED bz_closed"
title="VERIFIED WONTFIX - [GEN9+] 2% perf drop in Unigine Heaven, 1% in Valley"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109505">bug 109505</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>RESOLVED
</td>
<td>VERIFIED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_VERIFIED bz_closed"
title="VERIFIED WONTFIX - [GEN9+] 2% perf drop in Unigine Heaven, 1% in Valley"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109505#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_VERIFIED bz_closed"
title="VERIFIED WONTFIX - [GEN9+] 2% perf drop in Unigine Heaven, 1% in Valley"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109505">bug 109505</a>
from <span class="vcard"><a class="email" href="mailto:eero.t.tamminen@intel.com" title="Eero Tamminen <eero.t.tamminen@intel.com>"> <span class="fn">Eero Tamminen</span></a>
</span></b>
<pre>(In reply to Mark Janes from <a href="show_bug.cgi?id=109505#c5">comment #5</a>)
<span class="quote">> Mesa engineers took a look at this, and decided that the performance penalty
> represents the cost of enabling preemption.</span >
>
<span class="quote">> Since the performance penalty is slight, the team decided not to address it.</span >
I assume it's the PIPE_CONTROL_RENDER_TARGET_FLUSH when toggling preemption.
Neither Heaven nor Valley use any of the draw types that require disabling
preemption, but they do use instancing.
GfxBench Manhattan tests use in addition to instancing, also Triangle FAN draw
type, but I didn't check how much they alternates those with the other draw
types & non-instancing draws (that can be pre-empted on GEN9). It's anyway
likely that they're slightly impacted also, but happily impact is below daily
variance.
<span class="quote">> Benchmarks will not measure the improvements to system responsiveness that
> come from this feature. Sometimes we need to make the choice that a
> benchmark score is not the most important indicator of our driver's
> performance, even if it is the most visible one.</span >
Yep, most important was bisecting this so that an informed decision can be done
about it.
VERIFIED.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>